From 103487790dc692147711e6baba5858aa919fa9c5 Mon Sep 17 00:00:00 2001
From: olli <olli@gabosh.net>
Date: Thu, 25 May 2023 15:21:03 +0200
Subject: [PATCH] check for empty vars

---
 dabo/functions/check_sell_conditions.sh | 34 +++++++++++++++----------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/dabo/functions/check_sell_conditions.sh b/dabo/functions/check_sell_conditions.sh
index 2212c5b..6921aa2 100644
--- a/dabo/functions/check_sell_conditions.sh
+++ b/dabo/functions/check_sell_conditions.sh
@@ -114,32 +114,40 @@ function check_sell_conditions_strategy {
   # check if the result (profit/loss until now) is lowering and sell if too low ()
   if [ -f ${f_TRADE_HIST_FILE_INTERIM} ] 
   then
-    local f_BUY_PRICE_2ND_LAST_RATE_DIFF=$(tail -n2 ${f_TRADE_HIST_FILE_INTERIM} | head -n1)
-    local f_diff_result=$(echo "${f_BUY_PRICE_LAST_RATE_DIFF} - (${f_BUY_PRICE_2ND_LAST_RATE_DIFF})" | bc | sed 's/^\./0./; s/^-\./-0./')
-    if [ $(echo "${f_diff_result} < ${SELL_IF_LAST_RATE_LOWER_THEN}" | bc -l) -ne 0 ] && [ $(echo "${f_BUY_PRICE_LAST_RATE_DIFF} > ${FEE}" | bc -l) -ne 0 ]
+    if [ -n "$SELL_IF_LAST_RATE_LOWER_THEN" ]
     then
-      f_SELL="Loss between last (${f_BUY_PRICE_LAST_RATE_DIFF}%) and 2nd last (${f_BUY_PRICE_2ND_LAST_RATE_DIFF}%) rate/result more then  ${SELL_IF_LAST_RATE_LOWER_THEN}% (${f_diff_result}%)"
+      local f_BUY_PRICE_2ND_LAST_RATE_DIFF=$(tail -n2 ${f_TRADE_HIST_FILE_INTERIM} | head -n1)
+      local f_diff_result=$(echo "${f_BUY_PRICE_LAST_RATE_DIFF} - (${f_BUY_PRICE_2ND_LAST_RATE_DIFF})" | bc | sed 's/^\./0./; s/^-\./-0./')
+      if [ $(echo "${f_diff_result} < ${SELL_IF_LAST_RATE_LOWER_THEN}" | bc -l) -ne 0 ] && [ $(echo "${f_BUY_PRICE_LAST_RATE_DIFF} > ${FEE}" | bc -l) -ne 0 ]
+      then
+        f_SELL="Loss between last (${f_BUY_PRICE_LAST_RATE_DIFF}%) and 2nd last (${f_BUY_PRICE_2ND_LAST_RATE_DIFF}%) rate/result more then  ${SELL_IF_LAST_RATE_LOWER_THEN}% (${f_diff_result}%)"
+      fi
     fi
 
-    # Sell if the last X time units is lower then FEE
-    if [ $(cat ${f_TRADE_HIST_FILE_INTERIM} | wc -l) -ge ${SELL_IF_LOWER_THEN_FEE_AFTER_PERIOD} ]
+    if [ -n "$SELL_IF_LOWER_THEN_FEE_AFTER_PERIOD" ]
     then
-      local f_BUY_PRICE_XND_LAST_RATE_DIFF=$(tail -n${SELL_IF_LOWER_THEN_FEE_AFTER_PERIOD} ${f_TRADE_HIST_FILE_INTERIM} | head -n1)
-      local f_diff_result=$(echo "${f_BUY_PRICE_LAST_RATE_DIFF} - (${f_BUY_PRICE_XND_LAST_RATE_DIFF})" | bc)
-      if [ $(echo "${f_diff_result} < ${FEE}" | bc -l) -ne 0 ]
+      # Sell if the last X time units is lower then FEE
+      if [ $(cat ${f_TRADE_HIST_FILE_INTERIM} | wc -l) -ge ${SELL_IF_LOWER_THEN_FEE_AFTER_PERIOD} ]
       then
-        f_SELL="Loss between last rate (${f_BUY_PRICE_LAST_RATE_DIFF}%) in ${SELL_IF_LOWER_THEN_FEE_AFTER_PERIOD} time units before more then ${FEE} (${f_diff_result}%)"
+        local f_BUY_PRICE_XND_LAST_RATE_DIFF=$(tail -n${SELL_IF_LOWER_THEN_FEE_AFTER_PERIOD} ${f_TRADE_HIST_FILE_INTERIM} | head -n1)
+        local f_diff_result=$(echo "${f_BUY_PRICE_LAST_RATE_DIFF} - (${f_BUY_PRICE_XND_LAST_RATE_DIFF})" | bc)
+        if [ $(echo "${f_diff_result} < ${FEE}" | bc -l) -ne 0 ]
+        then
+          f_SELL="Loss between last rate (${f_BUY_PRICE_LAST_RATE_DIFF}%) in ${SELL_IF_LOWER_THEN_FEE_AFTER_PERIOD} time units before more then ${FEE} (${f_diff_result}%)"
+        fi
       fi
     fi
   fi
 
   # Sell on MACD Condition
-  if [ $(echo "${f_macd_histogram_relation} < ${SELL_MACD_RELATION_FROM}" | bc -l) -ne 0 ]
+  if [ -n "$SELL_MACD_RELATION_FROM" ]
   then
-    f_SELL="MACD condition met"
+    if [ $(echo "${f_macd_histogram_relation} < ${SELL_MACD_RELATION_FROM}" | bc -l) -ne 0 ]
+    then
+      f_SELL="MACD condition met"
+    fi
   fi
 
-
   # Sell on RSI conditions
   if \
    [ ${f_rsi5} -le ${SELL_RSI5_SIGNAL_UNTIL} ] && \